On Mon, Sep 02, 2024 at 01:52:59PM GMT, Gao Xiang wrote:
> Hi Yiyang,
>
> On 2024/9/2 12:50, Yiyang Wu wrote:
> How about not changing this, but add another if for this.
> if (S_ISLNK(inode->i_mode)) {
> err = erofs_fill_symlink(inode, kaddr, ofs);
> if (err)
> goto err_out;
> }
>
Yeah, i've decided on this before. But my initial intention is to avoid
another if statement. Sure, i will change this.
>
> if (inode->i_link)
>
> I'm not sure if `scripts/checkpatch.pl` still has the rule,
> but EROFS codebase don't compare against NULL.
>
Fixed.
> Thanks,
> Gao Xiang
>
> > /*
> > * Return the DIO alignment restrictions if requested.
>
Some of the styling bugs are introduced by clang-format, it's included in root
so i accidentally
formatted the code. I will fix them in next version.
Best Regards,
Yiyang Wu
