Re: [PATCH] erofs-utils: lib: fix compressed packed inodes

[Gao Xiang]

Hi Danny,

Thanks for the patch!
Sorry I somewhat missed the previous email..

On 2024/9/22 13:08, Danny Lin wrote:

Gentle bump — let me know if anything needs to be changed!

Does the following change resolve the issue too?

Also I think it
Fixes: 2fdbd28ad4a3 ("erofs-utils: lib: fix uncompressed packed inode")

@@ -1927,7 +1926,7 @@ struct erofs_inode 
*erofs_mkfs_build_special_from_fd(struct erofs_sb_info *sbi,

                DBG_BUGON(!ictx);
                ret = erofs_write_compressed_file(ictx);
-               if (ret && ret != -ENOSPC)
+               if (ret != -ENOSPC)
                         return ERR_PTR(ret);

                ret = lseek(fd, 0, SEEK_SET);

Thanks,
Gao Xiang

Thanks,
Danny