On Tue 02-06-26 12:10:07, Christian Brauner wrote: > blk_mode_t and fop_flags_t are both plain 'unsigned int __bitwise' flag > typedefs, exactly like the gfp_t, slab_flags_t and fmode_t that already > live in <linux/types.h>. Move them there so they are available > everywhere without having to drag in a subsystem header. > > Signed-off-by: Christian Brauner (Amutable) <[email protected]>
Makes sense. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > include/linux/blkdev.h | 2 -- > include/linux/fs.h | 2 -- > include/linux/types.h | 2 ++ > 3 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 890128cdea1c..c8494d64a69d 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -126,8 +126,6 @@ struct blk_integrity { > unsigned char pi_tuple_size; > }; > > -typedef unsigned int __bitwise blk_mode_t; > - > /* open for reading */ > #define BLK_OPEN_READ ((__force blk_mode_t)(1 << 0)) > /* open for writing */ > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 11559c513dfb..e9346be8470f 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1921,8 +1921,6 @@ struct dir_context { > struct io_uring_cmd; > struct offset_ctx; > > -typedef unsigned int __bitwise fop_flags_t; > - > struct file_operations { > struct module *owner; > fop_flags_t fop_flags; > diff --git a/include/linux/types.h b/include/linux/types.h > index 608050dbca6a..ef026585420b 100644 > --- a/include/linux/types.h > +++ b/include/linux/types.h > @@ -163,6 +163,8 @@ typedef u32 dma_addr_t; > typedef unsigned int __bitwise gfp_t; > typedef unsigned int __bitwise slab_flags_t; > typedef unsigned int __bitwise fmode_t; > +typedef unsigned int __bitwise blk_mode_t; > +typedef unsigned int __bitwise fop_flags_t; > > #ifdef CONFIG_PHYS_ADDR_T_64BIT > typedef u64 phys_addr_t; > > -- > 2.47.3 > -- Jan Kara <[email protected]> SUSE Labs, CR
