Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see
if it would identify any significant bugs. The analysis
turned up 38 mostly minor issues which are enumerated here
with patches. We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.
Thanks,
Brian Behlendorf <[EMAIL PROTECTED]>, and
Herb Wartens <[EMAIL PROTECTED]>
-----------------------------------------------------------------------------
Coverity ID: 2: Deadcode
Looks like ss_current_request is a macro that will set code to 0. This test
will always be false. I will remove this error case.
Index: e2fsprogs+chaos/lib/ss/help.c
===================================================================
--- e2fsprogs+chaos.orig/lib/ss/help.c
+++ e2fsprogs+chaos/lib/ss/help.c
@@ -49,10 +49,6 @@ void ss_help (argc, argv, sci_idx, info_
register ss_data *info;
request_name = ss_current_request(sci_idx, &code);
- if (code != 0) {
- ss_perror(sci_idx, code, "");
- return; /* no ss_abort_line, if invalid invocation */
- }
if (argc == 1) {
ss_list_requests(argc, argv, sci_idx, info_ptr);
return;
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
