On Wed, 2007-03-21 at 14:54 -0400, Theodore Tso wrote:
> On Fri, Feb 09, 2007 at 06:11:09PM -0800, Brian D. Behlendorf wrote:
> > Add an extra byte to EXT2_NAME_LEN in the static allocation for the
> > required trailing null. This allows filenames up to the maximum
> > length of EXT2_NAME_LEN withover an overrun.
> >
> > Coverity ID: 11: Overrun Static
> >
> > - thislen = ((dirent->name_len & 0xFF) < EXT2_NAME_LEN) ?
> > + thislen = ((dirent->name_len & 0xFF) <= EXT2_NAME_LEN) ?
> > (dirent->name_len & 0xFF) : EXT2_NAME_LEN;
>
> This change is largely meaningless/unnecessary, since if
> *dirent->name_len & 0xFF) is equal to EXT2_NAME_LEN it doesn't matter
> which path is chosen; was there a reason for the change.
#define EXT2_NAME_LEN 255
How about this?
thislen = dirent->name_len & 0xFF;
--
David Kleikamp
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
