Variable "free" was declarated as __u64 so conidition (free < 0) always
false, even if free was overflowed during substraction.
---
 fs/ext4/balloc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 43ae8f8..a9655f1 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -1909,8 +1909,8 @@ void ext4_rebalance_reservation(struct 
ext4_reservation_slot *rs, __u64 free)
                        chunk = free;
                if (rs[i].rs_reserved || i == smp_processor_id()) {
                        rs[i].rs_reserved = chunk;
+                       BUG_ON(free < chunk);
                        free -= chunk;
-                       BUG_ON(free < 0);
                }
        }
        BUG_ON(free);
-- 
1.5.2

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to