Hi Valerie,
My apologies not having the time to review your patches until now.
On Thu, Aug 30, 2007 at 05:28:35PM +0200, Valerie Clement wrote:
> This is a series of 8 patches that prepares for the 64-bit block number
> support in e2fsprogs:
In general, could people please use a fill column of 72 when sending
e-mail messages, writing C code, and writing git commit logs? It
makes life easier for people who still use 80 column screens, and it
is the kernel standard. Thanks!
> - change a few variable types to blk_t type to support 64-bit block
> numbers in a next step,
It's good to clean this up, but this presumes that blk_t is going to
change to a 64-bit type. I'd much rather *add* a blk64_t, and keep
blk_t at 32 bits. This patch series in a number of places makes the
presumption that blk_t will change size --- in particular when it
creates new interfaces that returns 64-bits through a blk_t. Please
don't do that.
> - introduce helper functions, similar to those existing in the ext4 kernel
> code, to access 64-bit block counters split in two 32-bit words.
These are the ones....
- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
