On Fri, Oct 16, 2015 at 09:07:17AM -0700, Jaegeuk Kim <[email protected]>
wrote:
> For fiemap, we should convert inline_data for user.
Sorry for not answeriung your other mails, I'm busy, but I just saw this
patch:
> + /* we don't need to use inline_data strictly */
> + if (f2fs_has_inline_data(inode)) {
> + ret = f2fs_convert_inline_inode(inode);
If that means that fiemap is no longer read-only but changes the layout, by
moving the data out of the inode, it's buggy - the correct way is to flag
those extents with FIEMAP_EXTENT_DATA_INLINE (and/or possibly other flags).
I didn't investigate the code, so maybe I am completely off here, just
guessing, really. If not, fiemap really is there to map the data extents, not
to de-optimise the filesystem. It's especially bad as fiemap is used by a lot
of tools to map disk layout.
If I am wrong, then please ignore my random mail here :)
--
The choice of a Deliantra, the free code+content MORPG
-----==- _GNU_ http://www.deliantra.net
----==-- _ generation
---==---(_)__ __ ____ __ Marc Lehmann
--==---/ / _ \/ // /\ \/ / [email protected]
-=====/_/_//_/\_,_/ /_/\_\
------------------------------------------------------------------------------
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
