On 05/13, Chao Yu wrote:
> mapping_read_folio_gfp() will return a folio, it should always be
> uptodate, let's check folio uptodate status to detect any potenial
> bug.
> 
> Signed-off-by: Chao Yu <c...@kernel.org>
> ---
> v2:
> - just add f2fs_bug_on(), get rid of error handling.
>  fs/f2fs/super.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 0ee783224953..8c77a625427c 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2973,6 +2973,12 @@ static ssize_t f2fs_quota_read(struct super_block *sb, 
> int type, char *data,
>                       goto repeat;
>               }
>  
> +             /*
> +              * should never happen, just leave f2fs_bug_on() here to catch
> +              * any potential bug.
> +              */
> +             f2fs_bug_on(sbi, !folio_test_uptodate(folio));

Applied with                F2FS_SB(sb)

> +
>               memcpy_from_folio(data, folio, offset, tocopy);
>               f2fs_folio_put(folio, true);
>  
> -- 
> 2.49.0


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to