On 07/10, Matthew Wilcox wrote:
> On Thu, Jul 10, 2025 at 02:26:38PM +0000, Jaegeuk Kim wrote:
> > On 07/10, Matthew Wilcox wrote:
> > > On Thu, Jul 10, 2025 at 03:17:28PM +0800, kernel test robot wrote:
> > > > >> fs/f2fs/data.c:58:56: error: passing 'const struct folio *' to
> > > > >> parameter of type 'struct folio *' discards qualifiers
> > > > >> [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> > > > 58 | return
> > > > folio_test_f2fs_gcing(fscrypt_pagecache_folio(folio));
> > > > |
> > > > ^~~~~
> > > > include/linux/fscrypt.h:527:67: note: passing argument to parameter
> > > > 'bounce_folio' here
> > > > 527 | static inline struct folio *fscrypt_pagecache_folio(struct
> > > > folio *bounce_folio)
> > >
> > > Ah; I changed only one of the definitions of fscrypt_pagecache_folio.
> > >
> > > Jaegeuk, can you fold in this fix?
> >
> > Will this break ext4?
> >
> > In ext4,
> > struct folio *folio = fi.folio;
> > ...
> >
> > if (fscrypt_is_bounce_folio(folio)) {
> > io_folio = folio;
> > folio = fscrypt_pagecache_folio(folio);
> > }
>
> No, you can pass a mutable folio to a function which takes a const
> folio. Just not the other way around.
Ah, I found it. Applied the above missing change.
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=70e71e8a0099d27857fdb9178187e72513d72141
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
