On 9/27/2025 2:18 AM, Zorro Lang wrote:
On Mon, Sep 01, 2025 at 10:03:30AM +0800, Chao Yu wrote:
This testcase tries to check whether f2fs can handle "usrjquota="
during remount correctly, it expects kernel will encounter NULL
pointer dereference bug w/o the fix ("f2fs: fix to avoid NULL pointer
dereference in f2fs_check_quota_consistency()").

Cc: Jaegeuk Kim <[email protected]>
Signed-off-by: Chao Yu <[email protected]>
---
  tests/f2fs/021     | 30 ++++++++++++++++++++++++++++++
  tests/f2fs/021.out |  2 ++
  2 files changed, 32 insertions(+)
  create mode 100755 tests/f2fs/021
  create mode 100644 tests/f2fs/021.out

diff --git a/tests/f2fs/021 b/tests/f2fs/021
new file mode 100755
index 00000000..c41760fc
--- /dev/null
+++ b/tests/f2fs/021
@@ -0,0 +1,30 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 Chao Yu.  All Rights Reserved.
+#
+# FS QA Test No. f2fs/021
+#
+# This testcase tries to check whether f2fs can handle "usrjquota="
+# during remount correctly
+#
+. ./common/preamble
+_begin_fstest auto quick mount
                                   ^^^^^^^^^^^^^
                                   quota remount

I'll help to add these two tags when I merge it. Others look good to me,
if you've maken sure it can trigger the bug you want to uncover.

Reviewed-by: Zorro Lang <[email protected]>

Thanks for the fix.

Thanks,


+
+_fixed_by_kernel_commit xxxxxxxxxxxx \
+       "f2fs: fix to avoid NULL pointer dereference in 
f2fs_check_quota_consistency()"
+
+_require_scratch
+
+_scratch_mkfs >> $seqres.full
+_scratch_mount "-o usrquota"
+quotacheck -uc $SCRATCH_MNT
+_scratch_unmount
+
+_scratch_mount "-o usrjquota=aquota.user,jqfmt=vfsold"
+_scratch_mount "-o remount,usrjquota=,jqfmt=vfsold"
+_scratch_unmount
+
+echo "Silence is golden"
+
+status=0
+exit
diff --git a/tests/f2fs/021.out b/tests/f2fs/021.out
new file mode 100644
index 00000000..09f4062d
--- /dev/null
+++ b/tests/f2fs/021.out
@@ -0,0 +1,2 @@
+QA output created by 021
+Silence is golden
--
2.49.0





_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to