2013/8/1, Gu Zheng <[email protected]>: > Hi Jeon, > > On 07/31/2013 10:33 PM, Namjae Jeon wrote: > >> From: Namjae Jeon <[email protected]> >> >> Add sysfs entries namely gc_long_idle and gc_short_idle to control the >> gc policy. Where long idle corresponds to selecting a cost benefit >> approach, >> while short idle corresponds to selecting a greedy approach to garbage >> collection. The selection is mutually exclusive one approach will work at >> any point. >> >> Signed-off-by: Namjae Jeon <[email protected]> >> Signed-off-by: Pankaj Kumar <[email protected]> >> --- >> Documentation/ABI/testing/sysfs-fs-f2fs | 12 +++++++ >> Documentation/filesystems/f2fs.txt | 8 +++++ >> fs/f2fs/gc.c | 22 ++++++++++-- >> fs/f2fs/gc.h | 4 +++ >> fs/f2fs/super.c | 59 >> +++++++++++++++++++++++++++++-- >> 5 files changed, 99 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs >> b/Documentation/ABI/testing/sysfs-fs-f2fs >> index 5f44095..96b62ea 100644 >> --- a/Documentation/ABI/testing/sysfs-fs-f2fs >> +++ b/Documentation/ABI/testing/sysfs-fs-f2fs >> @@ -19,4 +19,16 @@ Description: >> Controls the default sleep time for gc_thread. Time >> is in milliseconds. >> >> +What: /sys/fs/f2fs/<disk>/gc_long_idle >> +Date: July 2013 >> +Contact: "Namjae Jeon" <[email protected]> >> +Description: >> + Controls the selection of gc policy. long_idle is used >> + to select the cost benefit approach for garbage collection. >> >> +What: /sys/fs/f2fs/<disk>/gc_short_idle >> +Date: July 2013 >> +Contact: "Namjae Jeon" <[email protected]> >> +Description: >> + Controls the selection of gc policy. short_idle is used >> + to select the greedy approach for garbage collection. >> diff --git a/Documentation/filesystems/f2fs.txt >> b/Documentation/filesystems/f2fs.txt >> index 2e9e873..06dd5d7 100644 >> --- a/Documentation/filesystems/f2fs.txt >> +++ b/Documentation/filesystems/f2fs.txt >> @@ -158,6 +158,14 @@ Files in /sys/fs/f2fs/<devname> >> time for the garbage collection thread. >> Time is >> in milliseconds. >> >> + gc_long_idle This parameter controls the selection of >> cost >> + benefit approach for garbage collectoin. >> Writing >> + 1 to this file will select the cost benefit >> policy. >> + >> + gc_short_idle This parameter controls the selection of >> greedy >> + approach for the garbage collection. >> Writing 1 >> + to this file will select the greedy >> policy. > Hi Gu. > Why introduce two opposite attributes? It'll cause some confusion condition > if we > double enable/disable them. Yes, it seem possible in that you're talking. Okay, I will make one gc_idle and we can use long idle and short idle accoding to setting values.
Thanks for review! > >> + >> >> ------------------------------------------------------------------------------ Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
