On Thu, Dec 05, 2013 at 06:57:14PM +0100, Andreas Gruenbacher wrote: > I see that get_acl and set_acl are being defined in some but not all symlink > inode operations (for example, btrfs them while ext4 does not), and that > posix_acl_xattr_set() doesn't check if set_acl is defined. Symlinks cannot > have ACLs, so set_acl should either never be defined for symlinks (and a NULL > check is then needed in posix_acl_xattr_set()), or it is defined in all inode > operations, and S_ISNLNK() check is needed in posix_acl_xattr_set(). That > latter check should probably be added in any case to be on the safe side.
Yes, we should add the check. We also in general should not have set_acl/get_acl on links and I'll look over it. > Patch 6 also declares posix_acl_prepare() but this function is never > introduced; this must be a leftover from a previous version. Indeed. Thanks for the review! ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
