Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Friday, September 26, 2014 12:55 PM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 1/4] f2fs: check the use of macros on block counts > and addresses > > This patch cleans up the existing and new macros for readability. > > Rule is like this. > > ,-----------------------------------------> MAX_BLKADDR -, > | ,------------- TOTAL_BLKS ----------------------------, > | | | > | ,- seg0_blkaddr ,----- sit/nat/ssa/main blkaddress | > block | | (SEG0_BLKADDR) | | | | (e.g., MAIN_BLKADDR) | > address 0..x................ a b c d ............................. > | | > global seg# 0...................... m ............................. > | | | > | `------- MAIN_SEGS -----------' > `-------------- TOTAL_SEGS ---------------------------' > | | > seg# 0..........xx.................. > > = Note = > o GET_SEGNO_FROM_SEG0 : blk address -> global segno > o GET_SEGNO : blk address -> segno > o START_BLOCK : segno -> starting block address > > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>
Looks good! Reviewed-by: Chao Yu <chao2...@samsung.com> I see SM_I(sbi)->segment_count in check_seg_range/check_block_count still not be instead with TOTAL_SEGS(sbi), how about insteading these together? Regards, Yu ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
