On Tue, Sep 30, 2014 at 02:01:58PM +0800, Chao Yu wrote: > > -----Original Message----- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Tuesday, September 23, 2014 12:53 PM > > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > > linux-f2fs-devel@lists.sourceforge.net > > Cc: Jaegeuk Kim > > Subject: [f2fs-dev] [PATCH 2/3] f2fs: introduce FITRIM in f2fs_ioctl > > > > This patch introduces FITRIM in f2fs_ioctl. > > In this case, f2fs will issue small discards and prefree discards as many as > > possible for the given area. > > > > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> > > Looks good! > > Reviewed-by: Chao Yu <chao2...@samsung.com> > > > + > > /* zero block will be discarded through the prefree list */ > > if (!se->valid_blocks || se->valid_blocks == max_blocks) > > return; > > > > + dmap = kzalloc(SIT_VBLOCK_MAP_SIZE, GFP_KERNEL); > > We can afford 64 bytes allocation in stack, how about altering dmap to a local > array to reduce memory pressure at that moment and avoid delay of allocation?
It's not a big deal. Fixed. Thanks, > > > + if (!dmap) > > + return; > > + ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
