Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:[email protected]] > Sent: Sunday, November 15, 2015 2:27 AM > To: He YunLei; He YunLei > Cc: [email protected]; > [email protected] > Subject: Re: [f2fs-dev] [PATCH] mkfs.f2fs: introduce -b option to support > specified fs size > formating > > Hello, > > On Sat, Nov 14, 2015 at 01:32:29PM +0800, He YunLei wrote: > > hi, > > > > We can specify fs size in function f2fs_parse_options as follow: > > if ((optind + 1) < argc) { > > /* We have a sector count. */ > > config.total_sectors = atoll(argv[optind+1]); > > which one is better? > > Yeah, there is. > I don't think we need to add redundant options.
Actually, Yes, it's redundant. But what I try to do is introducing an option what can be used more simply by users of mkfs.f2fs. That means: 1. user do not need take time to calculate total sector number of our new fs; 2. It will not make any trouble for the user who does not know the sector size of storage device. One more intention here is to fix the mismatch between of parameter passed in _scratch_mkfs_sized and parameter received in mkfs.f2fs. As one is block size, and another is sector size. > > > > > Thanks > > > > On 2015/11/10 16:48, Chao Yu wrote: > > > This patch introduces a new option '-b', with this option user can specify > > > required fs size for formating. _scratch_mkfs_sized in xfstest is one of > > > user cases. > > We need to add one for f2fs in xfstest. Yeah, I'm prepare to previously once this patch can be merged. > Actually, I have a patch pending in my local xfstest. > Let me submit that sooner or later. :) Good, glad to see we can make xfstest supporting mkfs_sized for f2fs. :) Thanks, > > Thanks, > > ------------------------------------------------------------------------------ > _______________________________________________ > Linux-f2fs-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ------------------------------------------------------------------------------ _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
