Hi Jaegeuk,
> -----Original Message-----
> From: Jaegeuk Kim [mailto:[email protected]]
> Sent: Sunday, January 10, 2016 9:10 AM
> To: [email protected]; [email protected];
> [email protected]
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful
> commit
>
> If there is an error during commit, we should keep the flag in order to
> abort it.
>
> Signed-off-by: Jaegeuk Kim <[email protected]>
> ---
> fs/f2fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index dfaed51..db0b2cb 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1374,10 +1374,10 @@ static int f2fs_ioc_commit_atomic_write(struct file
> *filp)
> return ret;
>
> if (f2fs_is_atomic_file(inode)) {
> - clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
It was added in 6282adbf932c ("f2fs: call set_page_dirty to attach i_wb for
cgroup ") to avoid panic in kernel with writeback supported cgroup. We
should keep it here.
> ret = commit_inmem_pages(inode, false);
> if (ret)
> goto err_out;
> + clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
How about setting atomic flag if there occurs an error during committing.
Thanks,
> }
>
> ret = f2fs_sync_file(filp, 0, LLONG_MAX, 0);
> --
> 2.6.3
>
>
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> _______________________________________________
> Linux-f2fs-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
