Hi Yunlei, On Tue, Feb 02, 2016 at 09:05:27PM +0800, Yunlei He wrote: > no need to wait inline file page writeback for no one > use it, so this patch delete unnecessary wait. > > Signed-off-by: Yunlei He <heyun...@huawei.com> > --- > fs/f2fs/inline.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c > index fc4d298..ec44640 100644 > --- a/fs/f2fs/inline.c > +++ b/fs/f2fs/inline.c > @@ -124,8 +124,6 @@ int f2fs_convert_inline_page(struct dnode_of_data *dn, > struct page *page) > if (err) > return err; > > - f2fs_wait_on_page_writeback(page, DATA, true); > -
I agreed. But, I worried about any corner case. How about adding f2fs_bug_on() here? Thanks, > if (PageUptodate(page)) > goto no_update; > > -- > 1.9.1 ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
