On Mon, Mar 21, 2016 at 11:30:38AM +0100, Marc Lehmann wrote:
> On Mon, Mar 21, 2016 at 11:18:35AM +0800, Chao Yu <[email protected]> 
> wrote:
> > > As you pointed out, it seems there is a bug in sanity check routine, which
> > > doesn't cover the large section case.
> > 
> > Actually, there is a bug in f2fs-tools 1.6.0, it will trigger sanity check 
> > failure
> > in f2fs kernel module since in mkfs.f2fs we will align segment_count and
> > segment_count_main with different size if parameter -s or -z is configured 
> > larger
> > than 1.
> > 
> > Following commit in dev branch of f2fs-tools has fixed this issue, could 
> > you test this
> > patch firstly?
> > ("mkfs.f2fs: set segment_count in super block correctly")
> 
> Stupid question from my side, does that mean we have to reformat existing
> volumes? Because mkfs clearly won't fix existing volumes, so fixing mkfs
> will not fix the issue.

Exactly.
The f2fs patch should be merged to take into account such the backward
compatibility.
And, I don't think wrong segment_count hurts the f2fs behavior.

Thanks,

> 
> A fix in the f2fs or fsck.f2fs would be needed for existing volumes.
> 
> -- 
>                 The choice of a       Deliantra, the free code+content MORPG
>       -----==-     _GNU_              http://www.deliantra.net
>       ----==-- _       generation
>       ---==---(_)__  __ ____  __      Marc Lehmann
>       --==---/ / _ \/ // /\ \/ /      [email protected]
>       -=====/_/_//_/\_,_/ /_/\_\

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to