As suggested by Richard Weinberger, we need to agree on and document a clear set of fscrypt-related error codes.
I identified several cases where the error codes are not consistent between or within filesystems, or are ambiguous with other errors. This patchset proposes several changes to resolve these problems. I believe we do still have some flexibility to make changes to these error codes since there are not many different users of filesystem-level encryption yet, and depending on these specific errors would be unusual. There have also already been cases where some of these error codes have changed before. Currently this patchset depends on the following patch being applied first: "fscrypto: move ioctl processing more fully into common code" Eric Biggers (5): fscrypt: use ENOKEY when file cannot be created w/o key fscrypt: use ENOTDIR when setting encryption policy on nondirectory fscrypt: use EEXIST when file already uses different policy fscrypt: remove user-triggerable warning messages fscrypt: pass up error codes from ->get_context() fs/crypto/fname.c | 4 +-- fs/crypto/policy.c | 73 ++++++++++++++++++++---------------------------------- fs/ext4/ialloc.c | 2 +- fs/ext4/namei.c | 4 ++- fs/f2fs/dir.c | 5 +++- fs/f2fs/namei.c | 4 +-- 6 files changed, 39 insertions(+), 53 deletions(-) -- 2.8.0.rc3.226.g39d4020 ------------------------------------------------------------------------------ _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
