On 2017/2/18 3:15, Jaegeuk Kim wrote: > Hi Yunlei, > > I also removed "segno = NULL_SEGNO;" in the beginning part near gc_more. > > Thanks, > > On 02/17, Yunlei He wrote: >> In FG_GC process, it will search victim section twice. This will >> cause some dirty section with less valid blocks skip garbage >> collection. >> >> section # 26425 : valid blocks # 3 >> 142.037567: get_victim_by_default: victim 26425 : valid blocks # 3 >> 142.037585: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 26425 ofs_unit = 1, >> pre_victim_secno = 26425, prefree = 0, free = 244 >> 142.039494: f2fs_get_victim: dev = (259,30), type = Hot DATA, policy = >> (Background GC, SSR-mode, Greedy), victim = 19022 ofs_unit = 1, >> pre_victim_secno = 26425, prefree = 0, free = 24 >> 142.070247: new_curseg: Debug: alloc new segment 26746 >> 142.244341: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 26054 ofs_unit = 1, >> pre_victim_secno = 26054, prefree = 0, free = 243 >> 142.254475: do_garbage_collect: Debug: FG_GC, seg_freed = 1 >> 142.293131: f2fs_get_victim: dev = (259,30), type = Warm DATA, policy = >> (Background GC, SSR-mode, Greedy), victim = 23466 ofs_unit = 1, >> pre_victim_secno = -1, prefree = 0, free = 244 >> 142.319001: f2fs_get_victim: dev = (259,30), type = Warm DATA, policy = >> (Background GC, SSR-mode, Greedy), victim = 23467 ofs_unit = 1, >> pre_victim_secno = -1, prefree = 0, free = 244 >> 142.368879: get_victim_by_default: victim 26425 : valid blocks # 3 >> 142.368894: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 26425 ofs_unit = 1, >> pre_victim_secno = 26425, prefree = 0, free = 244 >> 142.378127: f2fs_get_victim: dev = (259,30), type = Hot DATA, policy = >> (Background GC, SSR-mode, Greedy), victim = 19612 ofs_unit = 1, >> pre_victim_secno = 26425, prefree = 0, free = 24 >> 142.416917: new_curseg: Debug: alloc new segment 26054 >> 142.656794: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 25404 ofs_unit = 1, >> pre_victim_secno = 25404, prefree = 0, free = 243 >> 142.662139: do_garbage_collect: Debug: FG_GC, seg_freed = 1 >> 142.684159: new_curseg: Debug: alloc new segment 25197 >> 142.685059: get_victim_by_default: victim 26425 : valid blocks # 3 >> 142.685079: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 26425 ofs_unit = 1, >> pre_victim_secno = 26425, prefree = 0, free = 243 >> 142.701427: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 26238 ofs_unit = 1, >> pre_victim_secno = 26238, prefree = 0, free = 243 >> 142.707105: do_garbage_collect: Debug: FG_GC, seg_freed = 1 >> 142.802444: f2fs_get_victim: dev = (259,30), type = Warm DATA, policy = >> (Background GC, SSR-mode, Greedy), victim = 23473 ofs_unit = 1, >> pre_victim_secno = -1, prefree = 0, free = 244 >> 142.804422: get_victim_by_default: victim 26425 : valid blocks # 3 >> 142.804443: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 26425 ofs_unit = 1, >> pre_victim_secno = 26425, prefree = 0, free = 244 >> 142.851567: f2fs_get_victim: dev = (259,30), type = Hot DATA, policy = >> (Background GC, SSR-mode, Greedy), victim = 19092 ofs_unit = 1, >> pre_victim_secno = 26425, prefree = 0, free = 24 >> 142.865014: new_curseg: Debug: alloc new segment 26238 >> 143.082245: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 26307 ofs_unit = 1, >> pre_victim_secno = 26307, prefree = 0, free = 244 >> 143.088252: do_garbage_collect: Debug: FG_GC, seg_freed = 1 >> 143.128307: new_curseg: Debug: alloc new segment 25404 >> 143.181846: get_victim_by_default: victim 26425 : valid blocks # 3 >> 143.181872: f2fs_get_victim: dev = (259,30), type = No TYPE, policy = >> (Foreground GC, LFS-mode, Greedy), victim = 26425 ofs_unit = 1, >> pre_victim_secno = 26425, prefree = 0, free = 244 >> >> Signed-off-by: Yunlei He <heyun...@huawei.com>
Reviewed-by: Chao Yu <yuch...@huawei.com> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
