On 2017/2/25 3:58, Jaegeuk Kim wrote:
> On 02/24, heyunlei wrote:
>> Hi Jaegeuk,
>>
>> Can you explain more about this? Besides, how about inplace update?
>
> Oh, sorry. I confused it was the inline_data conversion. ;)
> Yup, we can avoid entire f2fs_lock_op like this. And we can avoid IPU as well,
> but it's quite difficult to detect that.
Seems when there is a large number of dirty inline data in page cache, then
trigger intensively writeback and CP can run out of free space?
Thanks,
>
>>From 146e4c1ca458b1e33bf7f658f8796a8763e67a4e Mon Sep 17 00:00:00 2001
> From: Yunlei He <heyun...@huawei.com>
> Date: Thu, 23 Feb 2017 20:31:20 +0800
> Subject: [PATCH] f2fs: no need lock_op in f2fs_write_inline_data
>
> Similar as f2fs_write_inode, f2fs_write_inline_data just
> mark inode page dirty, so it's no need to write inline data
> under read lock of cp_rwsem.
>
> Signed-off-by: Yunlei He <heyun...@huawei.com>
> Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>
> ---
> fs/f2fs/data.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 80f9863dc4b0..9e51c5e40ce1 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1414,9 +1414,12 @@ static int __write_data_page(struct page *page, bool
> *submitted,
> goto redirty_out;
>
> err = -EAGAIN;
> - f2fs_lock_op(sbi);
> - if (f2fs_has_inline_data(inode))
> + if (f2fs_has_inline_data(inode)) {
> err = f2fs_write_inline_data(inode, page);
> + if (!err)
> + goto out;
> + }
> + f2fs_lock_op(sbi);
> if (err == -EAGAIN)
> err = do_write_data_page(&fio);
> if (F2FS_I(inode)->last_disk_size < psize)
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
