On 2017/2/25 2:12, Jaegeuk Kim wrote: > > This is to handle only one case in which: > > 1. uses old kernel without this flag, > 2. calls fsync and gets sudden power-cut, > 3. updates new kernel having this flag before mount. > > Then, if we do not check this flag at mount time, we will lose the last > fsync'ed > node blocks. >
So I just send a v2 patch to only change to macro in fill_node_footer_blkaddr and allocate_segment_by_default, these two functions are called frequently, so it is better to use macro code. And I remain the original checking code in is_recoverable_dnode, this function is called only once after mount, it's OK. -- Thanks, Yunlong Song ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
