Hi Yunlong,

On 2017/8/26 19:46, Yunlong Song wrote:
> In come corner case, the reserved segments are used to do gc, and there are
> not enough free segments for write checkpoint to finish its job, then the
> gc process will fail to change the prefree segments to free segments.

How about doing investigate that why we haven't enough free segment for GC?

Thanks,

> 
> Signed-off-by: Yunlong Song <yunlong.s...@huawei.com>
> ---
>  fs/f2fs/gc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index cd147e7..c8a828f 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1056,6 +1056,13 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>       if (!sync) {
>               if (has_not_enough_free_secs(sbi, sec_freed, 0)) {
>                       segno = NULL_SEGNO;
> +                     if (prefree_segments(sbi) &&
> +                             has_not_enough_free_secs(sbi,
> +                                     reserved_sections(sbi), 0)) {
> +                             ret = write_checkpoint(sbi, &cpc);
> +                             if (ret)
> +                                     goto stop;
> +                     }
>                       goto gc_more;
>               }
>  
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to