Hi Jaegeuk, I still can hit kernel panic with this patch, the reason is reorder of log header during mkfs is not actually executed, it needs to change as below.
On 2017/8/28 17:47, Chao Yu wrote: > On 2017/8/26 8:10, Jaegeuk Kim wrote: >> We should avoid i==j, otherwise we always assign 0~5 segments. >> >> Signed-off-by: Jaegeuk Kim <[email protected]> > > Reviewed-by: Chao Yu <[email protected]> > >> --- >> mkfs/f2fs_format.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c >> index b379e80..219c2a7 100644 >> --- a/mkfs/f2fs_format.c >> +++ b/mkfs/f2fs_format.c >> @@ -123,7 +123,7 @@ static void verify_cur_segs(void) >> >> for (i = 0; i < NR_CURSEG_TYPE; i++) { >> for (j = 0; j < NR_CURSEG_TYPE; j++) >> - if (c.cur_seg[i] == c.cur_seg[j]) >> + if (i != j && c.cur_seg[i] == c.cur_seg[j]) >> break; if (i != j && c.cur_seg[i] == c.cur_seg[j]) goto reorder; return; reorder: c.cur_seg[0] = 0; Thanks, >> } >> >> > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Linux-f2fs-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
