On 2017/12/8 13:44, heyunlei wrote: > > >> -----Original Message----- >> From: Jaegeuk Kim [mailto:[email protected]] >> Sent: Friday, December 08, 2017 1:27 PM >> To: heyunlei >> Cc: Yuchao (T); [email protected]; Wangbintian; Jianing >> (Euler) >> Subject: Re: [f2fs-dev][PATCH RFC] f2fs: fix an error case of missing update >> inode page >> >> On 12/05, Yunlei He wrote: >>> -Thread A Thread B >>> >>> -write_checkpoint >>> -block_operations >>> -f2fs_unlock_all -f2fs_sync_file >>> -f2fs_write_inode >>> >>> -f2fs_inode_synced >>> >>> -f2fs_sync_inode_meta >>> -sync_node_pages >>> >>> -set_page_drity >>> >>> In this case, if sudden power off without next new checkpoint, >>> the last inode page update will lost. wb_writeback is same with >>> fsync. >> >> BTW, what do you mean wb_writeback is same with fsync? > > Background write back will call f2fs_write_inode, which is same with > f2fs_sync_file.
Can you add related call stack in commit log? Other part looks good to me. Reviewed-by: Chao Yu <[email protected]> Thanks, ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
