On 2018/1/27 11:53, heyunlei wrote: > > >> -----Original Message----- >> From: Yuchao (T) >> Sent: Saturday, January 27, 2018 11:30 AM >> To: heyunlei; [email protected]; [email protected] >> Cc: Wangbintian; Jianing (Euler) >> Subject: Re: [f2fs-dev][PATCH] fsck: fix missing endian conversion >> >> On 2018/1/26 17:31, Yunlei He wrote: >>> This patch fix missing endian conversion in function >>> build_nat_area_bitmap >> >> I note that there are some missing cases for f2fs_nat_entry::blocik_addr, >> how about fixing them in this patch too? > > 2224 /* Clear the original bit and count */ > 2225 if (fsck->entries[nid].block_addr != 0x0) { > > You mean here? I checked the whole function and found only here > exist this problem. Because of comparing with zero, so I didn't change > here in previous patch.
Yes, how about just using if (f2fs_nat_entry::blocik_addr) in both write_nat_bits and build_nat_area_bitmap. Thanks, > > Thanks. > > 2226 fsck->chk.valid_nat_entry_cnt--; > 2227 f2fs_clear_bit(nid, fsck->nat_area_bitmap); > 2228 if (le32_to_cpu(fsck->entries[nid].ino) == nid) > 2229 fsck->nat_valid_inode_cnt--; > 2230 } > >> >> Thanks, > > > . > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
