On 2018/5/18 9:10, Jaegeuk Kim wrote: > On 05/16, Anatoly Pugachev wrote: >> Hello! >> >> The following patch disables loading of f2fs module on architectures >> which have PAGE_SIZE > 4096 , since it is impossible to mount f2fs on >> such architectures , log messages are: >> >> root@ttip:/1/mator/xfstests-dev# mount -t f2fs /dev/vdiskb1 /mnt >> mount: /mnt: wrong fs type, bad option, bad superblock on >> /dev/vdiskb1, missing codepage or helper program, or other error. >> root@ttip:/1/mator/xfstests-dev# file -s /dev/vdiskb1 >> /dev/vdiskb1: F2FS filesystem, >> UUID=1d8b9ca4-2389-4910-af3b-10998969f09c, volume name "" >> >> May 15 18:03:13 ttip kernel: F2FS-fs (vdiskb1): Invalid >> page_cache_size (8192), supports only 4KB >> May 15 18:03:13 ttip kernel: F2FS-fs (vdiskb1): Can't find valid F2FS >> filesystem in 1th superblock >> May 15 18:03:13 ttip kernel: F2FS-fs (vdiskb1): Invalid >> page_cache_size (8192), supports only 4KB >> May 15 18:03:13 ttip kernel: F2FS-fs (vdiskb1): Can't find valid F2FS >> filesystem in 2th superblock >> May 15 18:03:13 ttip kernel: F2FS-fs (vdiskb1): Invalid >> page_cache_size (8192), supports only 4KB >> >> which was introduced by git commit 5c9b469295fb6b10d98923eab5e79c4edb80ed20 >> >> tested on git kernel v4.17-rc5-20-g21b9f1c7e319 >> >> Signed-off-by: Anatoly Pugachev <mator...@gmail.com> >> --- >> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index 42d564c5ccd0..3071771bf261 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -3063,6 +3063,11 @@ static int __init init_f2fs_fs(void) >> { >> int err; >> >> + if (PAGE_SIZE > 4096) { > > It looks like > if (PAGE_SIZE != F2FS_BLKSIZE) > > >> + printk("F2FS not supported on PAGE_SIZE > 4096\n");
In addition, printk("F2FS not supported on PAGE_SIZE(%lu) != %d\n", PAGE_SIZE, F2FS_BLKSIZE); return -EINVAL; Thanks, >> + return -1; >> + } >> + >> f2fs_build_trace_ios(); >> >> err = init_inodecache(); >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel