[f2fs-dev] [PATCH V3 8/9] fsverity: Move verity status check to fsverity_file_open

[Chandan Rajendra]

Instead of conditionally checking for verity status of an inode before
invoking fsverity_file_open(), this commit moves the check inside the
definition of fsverity_file_open().

Signed-off-by: Chandan Rajendra <chan...@linux.vnet.ibm.com>
---
 fs/ext4/file.c    | 8 +++-----
 fs/f2fs/file.c    | 8 +++-----
 fs/verity/setup.c | 3 +++
 3 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 30fbd663354f..b404a857cd48 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -444,11 +444,9 @@ static int ext4_file_open(struct inode * inode, struct 
file * filp)
        if (ret)
                return ret;
 
-       if (IS_VERITY(inode)) {
-               ret = fsverity_file_open(inode, filp);
-               if (ret)
-                       return ret;
-       }
+       ret = fsverity_file_open(inode, filp);
+       if (ret)
+               return ret;
 
        /*
         * Set up the jbd2_inode if we are opening the inode for
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 2eb4821d95d1..925c0d9608da 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -491,11 +491,9 @@ static int f2fs_file_open(struct inode *inode, struct file 
*filp)
        if (err)
                return err;
 
-       if (IS_VERITY(inode)) {
-               err = fsverity_file_open(inode, filp);
-               if (err)
-                       return err;
-       }
+       err = fsverity_file_open(inode, filp);
+       if (err)
+               return err;
 
        filp->f_mode |= FMODE_NOWAIT;
 
diff --git a/fs/verity/setup.c b/fs/verity/setup.c
index 08b609127531..bc463dc601b1 100644
--- a/fs/verity/setup.c
+++ b/fs/verity/setup.c
@@ -771,6 +771,9 @@ static int setup_fsverity_info(struct inode *inode)
  */
 int fsverity_file_open(struct inode *inode, struct file *filp)
 {
+       if (!IS_VERITY(inode))
+               return 0;
+
        if (filp->f_mode & FMODE_WRITE) {
                pr_debug("Denying opening verity file (ino %lu) for write\n",
                         inode->i_ino);
-- 
2.19.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel