On 2019/5/15 2:13, Hagbard Celine wrote: > 2019-04-02 15:31 GMT+02:00, Chao Yu <c...@kernel.org>: >> On 2019-4-2 20:41, Hagbard Celine wrote: >>> That seems to have fixed it. No more errors in syslog after extracting >>> my stage3 tarball. Also ran a couple of kernel compiles on a partition >>> mounted with data_flush and system seems stable. >> >> Thanks a lot for your quick test. :) > > My test might have been a little too quick, or I found another > data_flush bug that behaves similar.
oops... >>>> >>>> - if (is_dir) >>>> - F2FS_I(inode)->cp_task = current; >>>> + F2FS_I(inode)->cp_task = current; If you're sure that this patch was applying before you test, I guess we need an extra barrier here to avoid out-of-order execution. smp_mb() >>>> >>>> filemap_fdatawrite(inode->i_mapping); >>>> >>>> - if (is_dir) >>>> - F2FS_I(inode)->cp_task = NULL; >>>> + F2FS_I(inode)->cp_task = NULL; Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
