On 2019-8-17 9:03, Jaegeuk Kim wrote:
> If we use later kernel having larger extra_isize, old fsck will delete
> entire old files.

Would it be better to construct the length based on existed features?

Thanks,

> 
> Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>
> ---
>  fsck/fsck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fsck/fsck.c b/fsck/fsck.c
> index 1708abe..b4e53db 100644
> --- a/fsck/fsck.c
> +++ b/fsck/fsck.c
> @@ -731,7 +731,7 @@ void fsck_chk_inode_blk(struct f2fs_sb_info *sbi, u32 nid,
>       if (f2fs_has_extra_isize(&node_blk->i)) {
>               if (c.feature & cpu_to_le32(F2FS_FEATURE_EXTRA_ATTR)) {
>                       if (node_blk->i.i_extra_isize >
> -                             cpu_to_le16(F2FS_TOTAL_EXTRA_ATTR_SIZE)) {
> +                                             4 * DEF_ADDRS_PER_INODE) {
>                               FIX_MSG("ino[0x%x] recover i_extra_isize "
>                                       "from %u to %u",
>                                       nid,
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to