This reverts commit 8648de2c581eeda7e412d6e38bf19e25bbb795ba. --- fs/f2fs/data.c | 88 ++++++------------------------------------------------- fs/f2fs/f2fs.h | 3 -- fs/f2fs/segment.c | 5 +--- 3 files changed, 10 insertions(+), 86 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 0ca530a..5af9810 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -348,20 +348,20 @@ static void __submit_merged_bio(struct f2fs_bio_info *io) io->bio = NULL; } -static bool __has_merged_page(struct bio *bio, struct inode *inode, +static bool __has_merged_page(struct f2fs_bio_info *io, struct inode *inode, struct page *page, nid_t ino) { struct bio_vec *bvec; struct page *target; struct bvec_iter_all iter_all; - if (!bio) + if (!io->bio) return false; if (!inode && !page && !ino) return true; - bio_for_each_segment_all(bvec, bio, iter_all) { + bio_for_each_segment_all(bvec, io->bio, iter_all) { target = bvec->bv_page; if (fscrypt_is_bounce_page(target)) @@ -411,7 +411,7 @@ static void __submit_merged_write_cond(struct f2fs_sb_info *sbi, struct f2fs_bio_info *io = sbi->write_io[btype] + temp; down_read(&io->io_rwsem); - ret = __has_merged_page(io->bio, inode, page, ino); + ret = __has_merged_page(io, inode, page, ino); up_read(&io->io_rwsem); } if (ret) @@ -481,61 +481,6 @@ int f2fs_submit_page_bio(struct f2fs_io_info *fio) return 0; } -int f2fs_merge_page_bio(struct f2fs_io_info *fio) -{ - struct bio *bio = *fio->bio; - struct page *page = fio->encrypted_page ? - fio->encrypted_page : fio->page; - - if (!f2fs_is_valid_blkaddr(fio->sbi, fio->new_blkaddr, - __is_meta_io(fio) ? META_GENERIC : DATA_GENERIC)) - return -EFSCORRUPTED; - - trace_f2fs_submit_page_bio(page, fio); - f2fs_trace_ios(fio, 0); - - if (bio && (*fio->last_block + 1 != fio->new_blkaddr || - !__same_bdev(fio->sbi, fio->new_blkaddr, bio))) { - __submit_bio(fio->sbi, bio, fio->type); - bio = NULL; - } -alloc_new: - if (!bio) { - bio = __bio_alloc(fio->sbi, fio->new_blkaddr, fio->io_wbc, - BIO_MAX_PAGES, false, fio->type, fio->temp); - bio_set_op_attrs(bio, fio->op, fio->op_flags); - } - - if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) { - __submit_bio(fio->sbi, bio, fio->type); - bio = NULL; - goto alloc_new; - } - - if (fio->io_wbc) - wbc_account_io(fio->io_wbc, page, PAGE_SIZE); - - inc_page_count(fio->sbi, WB_DATA_TYPE(page)); - - *fio->last_block = fio->new_blkaddr; - *fio->bio = bio; - - return 0; -} - -static void f2fs_submit_ipu_bio(struct f2fs_sb_info *sbi, struct bio **bio, - struct page *page) -{ - if (!bio) - return; - - if (!__has_merged_page(*bio, NULL, page, 0)) - return; - - __submit_bio(sbi, *bio, DATA); - *bio = NULL; -} - void f2fs_submit_page_write(struct f2fs_io_info *fio) { struct f2fs_sb_info *sbi = fio->sbi; @@ -2004,8 +1949,6 @@ int f2fs_do_write_data_page(struct f2fs_io_info *fio) } static int __write_data_page(struct page *page, bool *submitted, - struct bio **bio, - sector_t *last_block, struct writeback_control *wbc, enum iostat_type io_type) { @@ -2031,8 +1974,6 @@ static int __write_data_page(struct page *page, bool *submitted, .need_lock = LOCK_RETRY, .io_type = io_type, .io_wbc = wbc, - .bio = bio, - .last_block = last_block, }; trace_f2fs_writepage(page, DATA); @@ -2131,13 +2072,10 @@ static int __write_data_page(struct page *page, bool *submitted, unlock_page(page); if (!S_ISDIR(inode->i_mode) && !IS_NOQUOTA(inode) && - !F2FS_I(inode)->cp_task) { - f2fs_submit_ipu_bio(sbi, bio, page); + !F2FS_I(inode)->cp_task) f2fs_balance_fs(sbi, need_balance_fs); - } if (unlikely(f2fs_cp_error(sbi))) { - f2fs_submit_ipu_bio(sbi, bio, page); f2fs_submit_merged_write(sbi, DATA); submitted = NULL; } @@ -2164,7 +2102,7 @@ static int __write_data_page(struct page *page, bool *submitted, static int f2fs_write_data_page(struct page *page, struct writeback_control *wbc) { - return __write_data_page(page, NULL, NULL, NULL, wbc, FS_DATA_IO); + return __write_data_page(page, NULL, wbc, FS_DATA_IO); } /* @@ -2180,8 +2118,6 @@ static int f2fs_write_cache_pages(struct address_space *mapping, int done = 0; struct pagevec pvec; struct f2fs_sb_info *sbi = F2FS_M_SB(mapping); - struct bio *bio = NULL; - sector_t last_block; int nr_pages; pgoff_t uninitialized_var(writeback_index); pgoff_t index; @@ -2258,20 +2194,17 @@ static int f2fs_write_cache_pages(struct address_space *mapping, } if (PageWriteback(page)) { - if (wbc->sync_mode != WB_SYNC_NONE) { + if (wbc->sync_mode != WB_SYNC_NONE) f2fs_wait_on_page_writeback(page, DATA, true, true); - f2fs_submit_ipu_bio(sbi, &bio, page); - } else { + else goto continue_unlock; - } } if (!clear_page_dirty_for_io(page)) goto continue_unlock; - ret = __write_data_page(page, &submitted, &bio, - &last_block, wbc, io_type); + ret = __write_data_page(page, &submitted, wbc, io_type); if (unlikely(ret)) { /* * keep nr_to_write, since vfs uses this to @@ -2320,9 +2253,6 @@ static int f2fs_write_cache_pages(struct address_space *mapping, if (nwritten) f2fs_submit_merged_write_cond(F2FS_M_SB(mapping), mapping->host, NULL, 0, DATA); - /* submit cached bio of IPU write */ - if (bio) - __submit_bio(sbi, bio, DATA); return ret; } diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 17382da..f1cf2843 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1056,8 +1056,6 @@ struct f2fs_io_info { bool retry; /* need to reallocate block address */ enum iostat_type io_type; /* io type */ struct writeback_control *io_wbc; /* writeback control */ - struct bio **bio; /* bio for ipu */ - sector_t *last_block; /* last block number in bio */ unsigned char version; /* version of the node */ }; @@ -3164,7 +3162,6 @@ void f2fs_submit_merged_write_cond(struct f2fs_sb_info *sbi, nid_t ino, enum page_type type); void f2fs_flush_merged_writes(struct f2fs_sb_info *sbi); int f2fs_submit_page_bio(struct f2fs_io_info *fio); -int f2fs_merge_page_bio(struct f2fs_io_info *fio); void f2fs_submit_page_write(struct f2fs_io_info *fio); struct block_device *f2fs_target_device(struct f2fs_sb_info *sbi, block_t blk_addr, struct bio *bio); diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index a661ac3..380e0ab 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -3253,10 +3253,7 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio) stat_inc_inplace_blocks(fio->sbi); - if (fio->bio) - err = f2fs_merge_page_bio(fio); - else - err = f2fs_submit_page_bio(fio); + err = f2fs_submit_page_bio(fio); if (!err) { update_device_state(fio); f2fs_update_iostat(fio->sbi, fio->io_type, F2FS_BLKSIZE); -- 2.7.4 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel