On Fri, Nov 15, 2019 at 11:22:27AM -0800, Eric Biggers wrote: > On Fri, Nov 15, 2019 at 07:28:53PM +0200, Jarkko Sakkinen wrote: > > > > I don't see anything obviously wrong. Just would reformat it a bit. > > How you tested it? > > > > I'm not sure all the blank lines you're suggesting would be an improvement. > The ones in fscrypt_provisioning_key_preparse() might make sense though.
OK. Some of this aesthics comes from the feedback that I've received during Intel SGX patch set review process (of course subsystem is different i.e. x86). I tend to agree at least that before a new conditional statement it is more readable if there is a blank line before it. > I'm working on an xfstest for this: > > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/xfstests-dev.git/commit/?h=fscrypt-provisioning&id=24ab6abb7cf6a80be44b7c72b73f0519ccaa5a97 > > It's not quite ready, though. I'll post it for review when it is. > > Someone is also planning to update Android userspace to use this. So if there > are any issues from that, I'll hear about it. Cool. Can you combine this patch and matching test (once it is done) to a patch set? /Jarkko _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
