Hi,

On 01/08, Piergiorgio Sartor wrote:
> Hi all,
> 
> I've a small box, with Fedora 31 up-to-date.
> 
> The system has LUKS + LVM + f2fs.
> 
> Since kernel 5.3.16-300.fc31.x86_64 the fstrim.service,
> triggered by the systemd service fstrim.timer or from
> command line, does return an error:
> 
> Starting Discard unused blocks on filesystems from /etc/fstab...
> fstrim: /home: FITRIM ioctl failed: Read-only file system
> fstrim: /: FITRIM ioctl failed: Read-only file system
> fstrim.service: Main process exited, code=exited, status=32/n/a
> fstrim.service: Failed with result 'exit-code'.
> Failed to start Discard unused blocks on filesystems from /etc/fstab.

It smells like trying fstrim along with /etc/fstab before mounting the
partitions?

> 
> Note the following:
> 1) Both /home and / are rw
> 2) LUKS and LVM allow discard to the underlying device
> 3) An other PC, with same layout, but ext4, does work as expected
> 4) kernel 5.4.7-200.fc31.x86_64 (latest for f31) has same result
> 5) fstrim -vA or -va does not return an error, exit code is 0,
> but it always says 0 (zero) bytes are trimmed:
> 
> /home: 0 B (0 bytes) trimmed on /dev/mapper/fedora--server-home
> /: 0 B (0 bytes) trimmed on /dev/mapper/fedora--server-root

This is normal. Since f2fs issues discard commands asynchronously, fstrim
just collects discard candidates and returns right away. Later, it will
actually issue the candidates in background. Whereas, if it was mounted as
"-o nodiscard", fstrim will wait for whole discard commands being issued
and completed as you expect.

Thanks,

> 
> 6) mount shows that the f2fs mounts have "discard" flag
> 
> So, I suspect there is something with f2fs which somehow
> confuses the trimming process.
> 
> I had a quick search, but I could not find any other
> similar report, except one about systemd, but that
> does not seem related.
> 
> Any idea? Suggestions?
> Debugging possibilities?
> 
> Thanks a lot in advance,
> 
> bye,
> 
> -- 
> 
> piergiorgio
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to