[f2fs-dev] [PATCH 1/3] f2fs: fix to disable compression on directory

[Chao Yu]

It needs to call f2fs_disable_compressed_file() to disable
compression on directory.

Signed-off-by: Chao Yu <yuch...@huawei.com>
---
 fs/f2fs/f2fs.h | 10 ++++++----
 fs/f2fs/file.c |  2 +-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 9274399d9505..4e80cbe130d9 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3850,10 +3850,12 @@ static inline u64 f2fs_disable_compressed_file(struct 
inode *inode)
 
        if (!f2fs_compressed_file(inode))
                return 0;
-       if (get_dirty_pages(inode))
-               return 1;
-       if (fi->i_compr_blocks)
-               return fi->i_compr_blocks;
+       if (S_ISREG(inode->i_mode)) {
+               if (get_dirty_pages(inode))
+                       return 1;
+               if (fi->i_compr_blocks)
+                       return fi->i_compr_blocks;
+       }
 
        fi->i_flags &= ~F2FS_COMPR_FL;
        stat_dec_compr_inode(inode);
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 1476a3bc6317..6cb3c6cae7cd 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1815,7 +1815,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 
iflags, u32 mask)
        }
 
        if ((iflags ^ masked_flags) & F2FS_COMPR_FL) {
-               if (S_ISREG(inode->i_mode) && (masked_flags & F2FS_COMPR_FL)) {
+               if (masked_flags & F2FS_COMPR_FL) {
                        if (f2fs_disable_compressed_file(inode))
                                return -EINVAL;
                }
-- 
2.18.0.rc1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel