On 2020/5/15 10:15, Jaegeuk Kim wrote: > Let's guarantee flusing dirty meta pages to avoid infinite loop.
What's the root cause? Race case or meta page flush failure? Thanks, > > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> > --- > fs/f2fs/checkpoint.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 620a386d82c1a..9a7f695d5adb3 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1266,6 +1266,9 @@ void f2fs_wait_on_all_pages(struct f2fs_sb_info *sbi, > int type) > if (unlikely(f2fs_cp_error(sbi))) > break; > > + if (type == F2FS_DIRTY_META) > + f2fs_sync_meta_pages(sbi, META, LONG_MAX, > + FS_CP_META_IO); > io_schedule_timeout(DEFAULT_IO_TIMEOUT); > } > finish_wait(&sbi->cp_wait, &wait); > @@ -1493,8 +1496,6 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, > struct cp_control *cpc) > sbi->last_valid_block_count = sbi->total_valid_block_count; > percpu_counter_set(&sbi->alloc_valid_block_count, 0); > > - /* Here, we have one bio having CP pack except cp pack 2 page */ > - f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO); > /* Wait for all dirty meta pages to be submitted for IO */ > f2fs_wait_on_all_pages(sbi, F2FS_DIRTY_META); > > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
