Sorry for the late reply. We had a long holiday last week.
The patch looks good to me~

Thanks,

2020년 10월 7일 (수) 오후 12:49, Eric Biggers <[email protected]>님이 작성:
>
> On Wed, Sep 30, 2020 at 05:25:02PM -0700, Eric Biggers wrote:
> > Add a test which verifies that encryption is done correctly when a file
> > on f2fs uses both compression and encryption at the same time.
> >
> > Patches 1-4 add prerequisites for the test, while patch 5 adds the
> > actual test.  Patch 2 also fixes a bug which could cause the existing
> > test generic/602 to fail in extremely rare cases.  See the commit
> > messages for details.
> >
> > The new test passes both with and without the inlinecrypt mount option.
> > It requires CONFIG_F2FS_FS_COMPRESSION=y.
> >
> > I'd appreciate the f2fs developers taking a look.
> >
> > Note, there is a quirk where the IVs in compressed files are off by one
> > from the "natural" values.  It's still secure, though it made the test
> > slightly harder to write.  I'm not sure how intentional this quirk was.
> >
> > Eric Biggers (5):
> >   fscrypt-crypt-util: clean up parsing --block-size and --inode-number
> >   fscrypt-crypt-util: fix IV incrementing for --iv-ino-lblk-32
> >   fscrypt-crypt-util: add --block-number option
> >   common/f2fs: add _require_scratch_f2fs_compression()
> >   f2fs: verify ciphertext of compressed+encrypted file
>
> Jaegeuk, Chao, Daeho: any comments on this?
>
> - Eric
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to