On 12/16, Chao Yu wrote: > Jaegeuk, > > Do you remember why we use i_acl_mode to store acl related mode? > Can we get rid of it?
IIRC, it is used for error handling, so it seems we can't remove it. > > Thanks, > > On 2020/12/16 17:16, Chao Yu wrote: > > On 2020/12/14 11:54, Weichao Guo wrote: > > > We should update the ~S_IRWXUGO part of inode->i_mode in __setattr_copy, > > > because posix_acl_update_mode updates mode based on inode->i_mode, > > > which finally overwrites the ~S_IRWXUGO part of i_acl_mode with old > > > i_mode. > > > > > > Testcase to reproduce this bug: > > > 0. adduser abc > > > 1. mkfs.f2fs /dev/sdd > > > 2. mount -t f2fs /dev/sdd /mnt/f2fs > > > 3. mkdir /mnt/f2fs/test > > > 4. setfacl -m u:abc:r /mnt/f2fs/test > > > 5. chmod +s /mnt/f2fs/test > > > > Good catch! > > > > > > > > Signed-off-by: Weichao Guo <[email protected]> > > > Signed-off-by: Bin Shu <[email protected]> > > > > Reviewed-by: Chao Yu <[email protected]> > > > > Thanks, > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > . > > _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
