On Fri 08-01-21 23:58:59, Eric Biggers wrote: > From: Eric Biggers <[email protected]> > > wbc->for_sync implies wbc->sync_mode == WB_SYNC_ALL, so there's no need > to check for both. Just check for WB_SYNC_ALL. > > Signed-off-by: Eric Biggers <[email protected]>
Looks good to me. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/fs-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 80ee9816d9df5..cee1df6e3bd43 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -1479,7 +1479,7 @@ __writeback_single_inode(struct inode *inode, struct > writeback_control *wbc) > * change I_DIRTY_TIME into I_DIRTY_SYNC. > */ > if ((inode->i_state & I_DIRTY_TIME) && > - (wbc->sync_mode == WB_SYNC_ALL || wbc->for_sync || > + (wbc->sync_mode == WB_SYNC_ALL || > time_after(jiffies, inode->dirtied_time_when + > dirtytime_expire_interval * HZ))) { > trace_writeback_lazytime(inode); > -- > 2.30.0 > -- Jan Kara <[email protected]> SUSE Labs, CR _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
