On 03/23, Chao Yu wrote:
> This reverts commit 938a184265d75ea474f1c6fe1da96a5196163789.
>
> Because that commit fails generic/050 testcase which expect failure
> during mount a recoverable readonly partition.
I think we need to change generic/050, since f2fs can recover this partition,
even though using it as readonly. And, valid checkpoint can allow for user to
read all the data without problem.
>
> Fixes: 938a184265d7 ("f2fs: give a warning only for readonly partition")
> Signed-off-by: Chao Yu <[email protected]>
> ---
> fs/f2fs/super.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index b48281642e98..2b78ee11f093 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -3952,10 +3952,12 @@ static int f2fs_fill_super(struct super_block *sb,
> void *data, int silent)
> * previous checkpoint was not done by clean system shutdown.
> */
> if (f2fs_hw_is_readonly(sbi)) {
> - if (!is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG))
> + if (!is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG)) {
> + err = -EROFS;
> f2fs_err(sbi, "Need to recover fsync data, but
> write access unavailable");
> - else
> - f2fs_info(sbi, "write access unavailable,
> skipping recovery");
> + goto free_meta;
> + }
> + f2fs_info(sbi, "write access unavailable, skipping
> recovery");
> goto reset_checkpoint;
> }
>
> --
> 2.29.2
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
