As beroal <[email protected]> reported: f2fs image can be corrupted after below testcase:
1. truncate -s $((256*1024*1024)) img 2. mkfs.f2fs -f img 3. mount -t f2fs -o loop img /mnt 4. xfs_io -f /mnt/file -c "pwrite 0 2M" -c "fsync" 5. umount /mnt 6. resize.f2fs -s -t 262144 img 7. fsck.f2fs img The root cause is we forgot to copy original sit/nat bitmap to new checkpoint during rebuild_checkpoint(), fix it. Reported-by: beroal <[email protected]> Signed-off-by: Chao Yu <[email protected]> --- fsck/resize.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fsck/resize.c b/fsck/resize.c index 46b1cfb218cf..b3920560974b 100644 --- a/fsck/resize.c +++ b/fsck/resize.c @@ -526,6 +526,11 @@ static void rebuild_checkpoint(struct f2fs_sb_info *sbi, memcpy(new_cp, cp, (unsigned char *)cp->sit_nat_version_bitmap - (unsigned char *)cp); + if (c.safe_resize) + memcpy((void *)new_cp + CP_BITMAP_OFFSET, + (void *)cp + CP_BITMAP_OFFSET, + F2FS_BLKSIZE - CP_BITMAP_OFFSET); + new_cp->checkpoint_ver = cpu_to_le64(cp_ver + 1); crc = f2fs_checkpoint_chksum(new_cp); -- 2.29.2 _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
