To fix:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal 
permissions '0444'.

Signed-off-by: Yangtao Li <[email protected]>
---
 fs/f2fs/debug.c | 2 +-
 fs/f2fs/sysfs.c | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
index 833325038ef3..542c20e9ea0c 100644
--- a/fs/f2fs/debug.c
+++ b/fs/f2fs/debug.c
@@ -611,7 +611,7 @@ void __init f2fs_create_root_stats(void)
 #ifdef CONFIG_DEBUG_FS
        f2fs_debugfs_root = debugfs_create_dir("f2fs", NULL);
 
-       debugfs_create_file("status", S_IRUGO, f2fs_debugfs_root, NULL,
+       debugfs_create_file("status", 0444, f2fs_debugfs_root, NULL,
                            &stat_fops);
 #endif
 }
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index 6642246206bd..204de4c2c818 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -1213,13 +1213,13 @@ int f2fs_register_sysfs(struct f2fs_sb_info *sbi)
                sbi->s_proc = proc_mkdir(sb->s_id, f2fs_proc_root);
 
        if (sbi->s_proc) {
-               proc_create_single_data("segment_info", S_IRUGO, sbi->s_proc,
+               proc_create_single_data("segment_info", 0444, sbi->s_proc,
                                segment_info_seq_show, sb);
-               proc_create_single_data("segment_bits", S_IRUGO, sbi->s_proc,
+               proc_create_single_data("segment_bits", 0444, sbi->s_proc,
                                segment_bits_seq_show, sb);
-               proc_create_single_data("iostat_info", S_IRUGO, sbi->s_proc,
+               proc_create_single_data("iostat_info", 0444, sbi->s_proc,
                                iostat_info_seq_show, sb);
-               proc_create_single_data("victim_bits", S_IRUGO, sbi->s_proc,
+               proc_create_single_data("victim_bits", 0444, sbi->s_proc,
                                victim_bits_seq_show, sb);
        }
        return 0;
-- 
2.32.0



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to