On 2021/12/27 17:40, Fengnan Chang wrote:
Compress page will invalidate in truncate block process too, so remove
redunant invalidate compress pages in f2fs_evict_inode.
In normal case, f2fs_evict_inode only called when i_nlink become 0, so
unlikely.
Signed-off-by: Fengnan Chang <[email protected]>
---
fs/f2fs/inode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index 2ab3b424735a..ef30f3698a97 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -751,7 +751,8 @@ void f2fs_evict_inode(struct inode *inode)
trace_f2fs_evict_inode(inode);
truncate_inode_pages_final(&inode->i_data);
- if (test_opt(sbi, COMPRESS_CACHE) && f2fs_compressed_file(inode))
+ if (unlikely(inode->i_nlink) && test_opt(sbi, COMPRESS_CACHE) &&
+ f2fs_compressed_file(inode))
unlikely is not necessary, how about:
if (test_opt(sbi, COMPRESS_CACHE) && f2fs_compressed_file(inode) &&
(inode->i_nlinke || is_bad_inode(inode)))
Thanks,
f2fs_invalidate_compress_pages(sbi, inode->i_ino);
if (inode->i_ino == F2FS_NODE_INO(sbi) ||
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
