FS_IOC_SETFLAGS ioctl should return EOPNOTSUPP if the file attribute
(e.g. FS_NOCOW_FL) is not supported, rather than silently ignoring it
and returning success.

Fixes: 9b1bb01c8ae7 (f2fs: convert to fileattr)
Signed-off-by: Harry Austen <[email protected]>
---
 fs/f2fs/file.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 92ec2699bc85..061bf35c2582 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3085,9 +3085,8 @@ int f2fs_fileattr_set(struct user_namespace *mnt_userns,
                return -EIO;
        if (!f2fs_is_checkpoint_ready(F2FS_I_SB(inode)))
                return -ENOSPC;
-       if (fsflags & ~F2FS_GETTABLE_FS_FL)
+       if (fsflags & ~F2FS_SETTABLE_FS_FL)
                return -EOPNOTSUPP;
-       fsflags &= F2FS_SETTABLE_FS_FL;
        if (!fa->flags_valid)
                mask &= FS_COMMON_FL;
 
-- 
2.34.1



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to