Current error handling is at risk of page leaks. However, we dot't seek
any failure scenarios, just use f2fs_bug_on.

Signed-off-by: Jack Qiu <jack....@huawei.com>
---
 fs/f2fs/file.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 100637b1adb3..edb03945ad36 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3968,10 +3968,10 @@ static int redirty_blocks(struct inode *inode, pgoff_t 
page_idx, int len)

        for (i = 0; i < page_len; i++, redirty_idx++) {
                page = find_lock_page(mapping, redirty_idx);
-               if (!page) {
-                       ret = -ENOMEM;
-                       break;
-               }
+
+               /* It will never fail, when page has pinned above */
+               f2fs_bug_on(sbi, !page);
+
                set_page_dirty(page);
                f2fs_put_page(page, 1);
                f2fs_put_page(page, 0);
--
2.31.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to