On 6/9/22 19:05, Peter Collingbourne wrote:
On Thu, Apr 21, 2022 at 03:18:15PM -0700, Bart Van Assche wrote:
+static_assert(sizeof(struct f2fs_dentry_block) == 4096, "");

I noticed that this static_assert fails when PAGE_SIZE is defined to
a value other than 4096.

I have to admit to being unfamiliar with f2fs. Is this an on-disk
data structure? If so, does it mean that non-4K page size kernels
are unable to mount f2fs file systems if the f2fs-tools were not
built with a matching PAGE_SIZE define?

In any event, maybe s/4096/PAGE_SIZE/g above is the correct fix
for now?

Hi Peter,

How this issue should be fixed depends on whether or not f2fs_dentry_block is an on-disk data structure. I'm not sure about the answer. Jaegeuk, can you help with answering this question?

Thanks,

Bart.


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to