On 2022/8/25 4:30, Jaegeuk Kim wrote:
Otherwise, pending checkpoints can contribute a race condition to give a
quota warning.

- Thread                      - checkpoint thread
                               add checkpoints to the list
do_remount()
  down_write(&sb->s_umount);
  f2fs_remount()
                               block_operations()
                                down_read_trylock(&sb->s_umount) = 0
  up_write(&sb->s_umount);
                                f2fs_quota_sync()
                                 dquot_writeback_dquots()
                                  WARN_ON_ONCE(!rwsem_is_locked(&sb->s_umount));

Or,

do_remount()
  down_write(&sb->s_umount);
  f2fs_remount()
                               create a ckpt thread
                               f2fs_enable_checkpoint() adds checkpoints
                              wait for f2fs_sync_fs()
                               trigger another pending checkpoint
                                block_operations()
                                 down_read_trylock(&sb->s_umount) = 0
  up_write(&sb->s_umount);
                                 f2fs_quota_sync()
                                  dquot_writeback_dquots()
                                   
WARN_ON_ONCE(!rwsem_is_locked(&sb->s_umount));

Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>

Reviewed-by: Chao Yu <c...@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to