On 2022/10/18 15:32, Yang Yingliang wrote:
Inject fault while probing module, kset_register() may fail,
if it fails, but the refcount of kobject is not decreased to
0, the name allocated in kobject_set_name() is leaked. Fix
this by calling kset_put(), so that name can be freed in
callback function kobject_cleanup().

unreferenced object 0xffff888101b7cc80 (size 8):
   comm "modprobe", pid 252, jiffies 4294691378 (age 31.760s)
   hex dump (first 8 bytes):
     66 32 66 73 00 88 ff ff                          f2fs....
   backtrace:
     [<000000001db5b408>] __kmalloc_node_track_caller+0x44/0x1b0
     [<000000002783a073>] kstrdup+0x3a/0x70
     [<00000000ead2b281>] kstrdup_const+0x63/0x80
     [<000000003e5cf8f7>] kvasprintf_const+0x149/0x180
     [<00000000c4d949ff>] kobject_set_name_vargs+0x56/0x150
     [<0000000044611660>] kobject_set_name+0xab/0xe0

Fixes: bf9e697ecd42 ("f2fs: expose features to sysfs entry")
Signed-off-by: Yang Yingliang <yangyingli...@huawei.com>

Reviewed-by: Chao Yu <c...@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to