Re: [f2fs-dev] [PATCH] f2fs: set zstd compress level correctly

Wed, 23 Nov 2022 16:56:12 -0800 


> On Nov 17, 2022, at 7:10 AM, Sheng Yong <[email protected]> wrote:
> 
> > 
> Fixes: cf30f6a5f0c6 ("lib: zstd: Add kernel-specific API")
> Signed-off-by: Sheng Yong <[email protected]>
> ---
> fs/f2fs/compress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
> index d315c2de136f2..74d3f2d2271f3 100644
> --- a/fs/f2fs/compress.c
> +++ b/fs/f2fs/compress.c
> @@ -346,7 +346,7 @@ static int zstd_init_compress_ctx(struct compress_ctx *cc)
>       if (!level)
>               level = F2FS_ZSTD_DEFAULT_CLEVEL;
> 
> -     params = zstd_get_params(F2FS_ZSTD_DEFAULT_CLEVEL, cc->rlen);
> +     params = zstd_get_params(level, cc->rlen);
>       workspace_size = zstd_cstream_workspace_bound(&params.cParams);
> 
>       workspace = f2fs_kvmalloc(F2FS_I_SB(cc->inode),
> -- 
> 2.25.1
> 

Thanks for the patch, and sorry for introducing the bug!
Looks like I missed this while rebasing that patch series.

Reviewed-by: Nick Terrell <[email protected]>

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel






















					Reply via email to