[f2fs-dev] [PATCH] f2fs: fix to handle filemap_fdatawrite() error in f2fs_ioc_decompress_file/f2fs_ioc_compress_file

[Yangtao Li via Linux-f2fs-devel]

It seems inappropriate that the current logic does not handle
filemap_fdatawrite() errors, so let's fix it.

Signed-off-by: Yangtao Li <frank...@vivo.com>
---
 fs/f2fs/file.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 15dabeac4690..6de2f27c4eec 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -4062,8 +4062,11 @@ static int f2fs_ioc_decompress_file(struct file *filp)
                if (ret < 0)
                        break;
 
-               if (get_dirty_pages(inode) >= blk_per_seg)
-                       filemap_fdatawrite(inode->i_mapping);
+               if (get_dirty_pages(inode) >= blk_per_seg) {
+                       ret = filemap_fdatawrite(inode->i_mapping);
+                       if (ret < 0)
+                               break;
+               }
 
                count -= len;
                page_idx += len;
@@ -4133,8 +4136,11 @@ static int f2fs_ioc_compress_file(struct file *filp)
                if (ret < 0)
                        break;
 
-               if (get_dirty_pages(inode) >= blk_per_seg)
-                       filemap_fdatawrite(inode->i_mapping);
+               if (get_dirty_pages(inode) >= blk_per_seg) {
+                       ret = filemap_fdatawrite(inode->i_mapping);
+                       if (ret < 0)
+                               break;
+               }
 
                count -= len;
                page_idx += len;
-- 
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel